Commit Graph

180 Commits

Author SHA1 Message Date
Phillip Potter
6e2f371df5 remove rtw_vmalloc preprocessor definition
Remove rtw_vmalloc preprocessor definition from include/osdep_service.h
as it now has no callers.

Link: https://lore.kernel.org/r/20210818234853.208448-3-phil@philpotter.co.uk
2021-10-11 15:46:55 +02:00
Phillip Potter
397bbaeacf convert only rtw_vmalloc call to vmalloc
Convert the only call to rtw_vmalloc in os_dep/ioctl_linux.c to the
kernel's existing vmalloc function, as rtw_malloc is just a preprocessor
definition for _rtw_vmalloc. The _rtw_vmalloc function is defined inline
and returns a u8, wrapping standard vmalloc. This behaviour is not necessary.

Link: https://lore.kernel.org/r/20210818234853.208448-2-phil@philpotter.co.uk
2021-10-11 15:45:31 +02:00
Greg Kroah-Hartman
76cefd5ae2 remove inline markings from functions in rtw_br_ext.c
The compiler is free to ignore, or follow, "inline" markings so they
really have no use in .c files, so just remove them.

This allows functions to properly show up as being unused when all
callers to them are removed, otherwise gcc does not warn you about this.

Link: https://lore.kernel.org/r/20210816073450.668993-1-gregkh@linuxfoundation.org
2021-10-11 15:15:20 +02:00
Michael Straube
c1f70ba056 use common ieee80211 constants
Many defined constants in wifi.h are unused and/or available from
<linux/ieee80211.h>, some with slightly different names. Remove
the constants from wifi.h and use the common ones. Rename where
necessary.

Link: https://lore.kernel.org/r/20210814165518.8672-1-straube.linux@gmail.com
2021-10-11 15:03:09 +02:00
Fabio M. De Francesco
22a000acb9 Remove defined but not used variables
Remove defined but not used const variables. Issues detected by GCC
running with -Wunused-const-variable option enabled.

Link: https://lore.kernel.org/r/20210814160804.11634-1-fmdefrancesco@gmail.com
2021-10-11 14:25:08 +02:00
Nathan Chancellor
c597fa83da Reorganize error handling in rtw_drv_init()
Looking at the error function as a whole, the error handling is odd
compared to the rest of the kernel, which prefers to set error codes on
goto paths, rather than a global "status" variable which determines the
error code at the end of the function and function calls in the case of
error.

Rearrange the error handling of this function to bring it more inline
with how the kernel does it in most cases, which helps readability.

Link: https://lore.kernel.org/r/20210812204027.338872-4-nathan@kernel.org
Link: https://lore.kernel.org/r/20210813201418.4018631-1-nathan@kernel.org
2021-10-11 14:22:28 +02:00
Nathan Chancellor
8d93cdeefa Remove unused static inline functions in rtw_recv.h
The functions are not used or are called
from functions that are not used so just remove them to remove the
warnings.

Link: https://lore.kernel.org/r/20210812204027.338872-2-nathan@kernel.org
2021-10-11 14:06:16 +02:00
Michael Straube
c8fd0937e4 replace custom hwaddr_aton_i() with mac_pton()
Replace custom hwaddr_aton_i() with mac_pton() in core/ioctl_linux.c
and remove the now unused function hwaddr_aton_i().

Link: https://lore.kernel.org/r/20210812132057.22579-1-straube.linux@gmail.com
2021-10-11 13:55:23 +02:00
Martin Kaiser
0faae6386e use IW_HANDLER to declare wext handlers
Use the IW_HANDLER macro to declare the handler functions for
wext ioctls. We don't have to skip unused ioctl numbers manually.

The same modification was applied to the deprecated rtl8188eu driver in
commit af249fce390f ("staging: rtl8188eu: use IW_HANDLER to declare wext
handlers").

Link: https://lore.kernel.org/r/20210807153636.11712-11-martin@kaiser.cx
2021-10-11 13:37:30 +02:00
Michael Straube
03af80bee9 replace custom macros with is_broadcast_ether_addr
Replace usage of custom macros with is_broadcast_ether_addr. All buffers
are properly aligned. Remove the now unsued macros MacAddr_isBcst and
IS_MAC_ADDRESS_BROADCAST.

Link: https://lore.kernel.org/r/20210805205010.31192-1-straube.linux@gmail.com
2021-10-11 13:29:13 +02:00
Martin Kaiser
2965c273c9 remove the RT_TRACE macro
We've deleted all RT_TRACE calls. The macro itself can now be removed
as well.

Link: https://lore.kernel.org/r/20210807153636.11712-13-martin@kaiser.cx
2021-10-11 13:18:29 +02:00
Larry Finger
9ad10523e3 Remove wrapper rtw_sleep_schedulable()
This wrapper is never used.

Link: https://lore.kernel.org/r/20210805192644.15978-6-Larry.Finger@lwfinger.net
2021-10-11 13:03:59 +02:00
Larry Finger
a5adfa895b Remove wrapper rtw_udelay_os()
This wrapper is a simple call to udelay(). Remove it.

Link: https://lore.kernel.org/r/20210805192644.15978-4-Larry.Finger@lwfinger.net
2021-10-11 13:00:27 +02:00
Larry Finger
7f8451a86e Remove wrapper rtw_mdelay_os()
This wrapper just calls mdelay(). Remove it.

Link: https://lore.kernel.org/r/20210805192644.15978-3-Larry.Finger@lwfinger.net
2021-10-11 12:57:06 +02:00
Carlos Garcés
5bc12edecb
Merge pull request #245 from CGarces/staging_cherrypick
Adapted commits from staging area
2021-10-11 12:18:18 +02:00
Carlos Garcés
cf246719f1 Remove wrapper for memset()
Link: 545d963a9e (diff-16d649c4743131c1aae5f812af5596dae6423bb63eaaf2990b8c89c9a681a913)
2021-10-11 12:09:34 +02:00
Carlos Garcés
76f68bbfcf Remove hidden warnings from makefile 2021-10-11 12:05:35 +02:00
Larry Finger
fdbea81f08 Remove wrapper routine rtw_msleep_os()
The effect of this macro is to call msleep(). Remove the wrapper.

Link: https://lore.kernel.org/r/20210805192644.15978-2-Larry.Finger@lwfinger.net
2021-10-11 10:44:02 +02:00
Larry Finger
1fcfef2e07 Remove rtw_yield_os()
This wrapper is just a call to yield().

Link: https://lore.kernel.org/r/20210805192644.15978-1-Larry.Finger@lwfinger.net
2021-10-11 10:44:02 +02:00
Larry Finger
f1aa80a838 Remove more empty routines
After removing some empty routines in os_dep/osdep_service.c, new routines
become empty. These include rtw_mfree_stainfo(),
_rtw_free_sta_xmit_priv_lock(), and rtw_mfree_recv_priv_lock.

Link: https://lore.kernel.org/r/20210805183717.23007-5-Larry.Finger@lwfinger.net
2021-10-11 10:44:02 +02:00
Larry Finger
51e1f13a91 Remove all calls to _rtw_spinlock_free()
This routine is empty, thus all calls to it can be removed.

Link: https://lore.kernel.org/r/20210805183717.23007-4-Larry.Finger@lwfinger.net
2021-10-11 10:44:02 +02:00
Larry Finger
34ec238387 Remove wrapper around vfree
This call is so simple that there is no need, or use, for a wrapper.

Link: https://lore.kernel.org/r/20210805183717.23007-3-Larry.Finger@lwfinger.net
2021-10-11 10:44:02 +02:00
Larry Finger
4d3d23dd24 Remove wrapper around do_div
Wrapper routine rtw_modular64() contains only a call to do_div() and
is used once in the code. Remove the wrapper.

Link: https://lore.kernel.org/r/20210803135223.12543-9-Larry.Finger@lwfinger.net
2021-10-11 10:44:02 +02:00
Larry Finger
d7c3737cd5 Remove wrappers for atomic operations
These wrappers were useful when this driver had the hooks for Windows,
but are no longer needed.

Link: https://lore.kernel.org/r/20210802192721.23110-4-Larry.Finger@lwfinger.net
2021-10-11 10:44:02 +02:00
Phillip Potter
e8b235e056 correct set/defined but unused warnings from debug cleanup
This patch fixes an existing warning
related to an array within include/rtw_security.h not being used.

Link: https://lore.kernel.org/r/20210731133804.196631-1-phil@philpotter.co.uk
2021-10-11 10:44:01 +02:00
Greg Kroah-Hartman
6b5e7665c9 remove rtw_usb_control_msg() macro
It is a wrapper around usb_control_msg() that does nothing, so remove
the macro and just call the correct USB function instead in the one
place it is used.

Link: https://lore.kernel.org/r/20210730092417.1014392-12-gregkh@linuxfoundation.org
2021-10-11 10:44:01 +02:00
Greg Kroah-Hartman
904e95f373 remove rtw_usb_bulk_msg() macro
No one is using this wrapper macro, so just remove it as it is
pointless.

Link: https://lore.kernel.org/r/20210730092417.1014392-11-gregkh@linuxfoundation.org
2021-10-11 10:44:01 +02:00
Greg Kroah-Hartman
ca6e4a43f7 remove include/nic_spec.h
No one was including this file, so just remove it.

Link: https://lore.kernel.org/r/20210730092417.1014392-10-gregkh@linuxfoundation.org
2021-10-11 10:44:01 +02:00
Greg Kroah-Hartman
361918ceb1 remove unused enum _NIC_VERSION
None of these enumerated values were used anywhere in the driver, so
just remove them all.

Link: https://lore.kernel.org/r/20210730092417.1014392-9-gregkh@linuxfoundation.org
2021-10-11 10:44:01 +02:00
Greg Kroah-Hartman
ac1790da7c remove rtw_mfree2d() function
It is just a wrapper around kfree(), so remove it and just call kfree()
instead.

Adaptation of: https://lore.kernel.org/r/20210730092417.1014392-7-gregkh@linuxfoundation.org
2021-10-11 10:44:01 +02:00
Larry Finger
1401b54fd0 Remove empty header file
File include/drv_types_linux.h is empty. Remove it.

Adaptation of: https://lore.kernel.org/r/20210729170930.23171-2-Larry.Finger@lwfinger.net
2021-10-10 23:13:31 +02:00
Carlos Garcés
bc765550ed
Merge pull request #246 from Mange/fix_ci
Fix libc6 dependency
2021-10-10 23:09:32 +02:00
Carlos Garcés
fa64647e38
Fix libc6 dependency 2021-10-10 23:02:43 +02:00
Carlos Garcés
4c9751be79
Merge pull request #244 from CGarces/fix_5.15
Fix buils with kernel 5.15
2021-10-09 13:46:06 +02:00
Carlos Garcés
59fd03940c Fix for kernel 5.15
Fixed compilation warnings with GCC 11
Fix libc6 dependency 2.34
2021-10-09 13:33:01 +02:00
Carlos Garcés
5464196753
Merge pull request #236 from CGarces/fix_5.12
Fixed 5.12 support.
2021-05-12 09:43:22 +02:00
Carlos Garcés
4013a01fe6
Fix libc6 2.33 dependency 2021-05-11 23:17:21 +02:00
Carlos Garcés
09c5222d59 Fixed 5.12 support. 2021-05-10 19:06:13 +02:00
Carlos Garcés
ab35c7e967
Merge pull request #233 from CGarces/fix_5.12
Add kernel 5.12(+) (GRO_DROP removed) support
2021-04-03 16:53:01 +02:00
Carlos Garcés
e103b7c701
Merge pull request #232 from CGarces/centos8_fix
Add RHEL/CENTOS 8 support
2021-04-03 16:52:43 +02:00
Carlos Garcés
6a9f1c3ab1
Merge pull request #227 from Mange/kernel_5.11
Fix wireless regulatory API misuse
2021-04-03 16:52:22 +02:00
clnhub
ac90a311a3 Add kernel 5.12(+) (GRO_DROP removed) support 2021-04-03 14:46:24 +00:00
Carlos
48460503c0 Add RHEL/CENTOS 8 support 2021-04-01 15:37:13 +00:00
Carlos Garces
8fa56156a8 Fix wireless regulatory API misuse
Port of 81f153faac
2021-03-11 23:39:00 +01:00
Carlos Garcés
6a758d54cf
Merge pull request #226 from CGarces/github_actions
Improved github actions
2021-03-06 17:34:09 +01:00
Carlos Garces
d062e34d79 Improved github actions
Added step to detect misuse of USB_VENDOR_ID_REALTEK
Added check for duplicated USB IDs
Check for .deb files before download it
Move git checkout before build step
2021-03-06 17:13:00 +01:00
Carlos Garcés
7e8858e0df
Merge pull request #222 from glebm/realtek-4.4.x-fix-gcc10
Fix build with gcc-10 (-Wrestrict)
Close #221
2021-02-06 17:18:48 +01:00
Gleb Mazovetskiy
d6e1690ae8 Fix build with gcc-10 (-Wrestrict)
Fixes errors such as this:

```
os_dep/linux/ioctl_mp.c:611:4: warning: 'sprintf' argument 3 overlaps destination object 'extra' [-Wrestrict]
error, forbidden warning:ioctl_mp.c:611
  611 |    sprintf(extra, "%s,pathb=%d", extra, txpower_inx);
```

Fixes #221
2021-02-06 17:13:16 +01:00
Carlos Garcés
722ebf1e6d
Merge pull request #223 from CGarces/fix_build
Github actions enhancements
2021-02-06 14:01:36 +01:00
Carlos
742f7f5329 Set fail-fast to false to avoid cancel all builds due temporal errors on kernel versions
Removed verbose to wget commands
Forced dpkg command to allow compilation if .deb installations fails due dependencies not needed for build.
2021-02-06 12:47:57 +00:00