From 3494bdce7b7fe530c5a0e74e7ee2bdb70c0b51c7 Mon Sep 17 00:00:00 2001 From: Justin McCarthy Date: Mon, 25 Jun 2018 17:50:07 -0700 Subject: [PATCH] prep version notification and release channel structure --- internal/cli/app.go | 45 ++++++++++++++++++++++++++++++++++++++------- 1 file changed, 38 insertions(+), 7 deletions(-) diff --git a/internal/cli/app.go b/internal/cli/app.go index cdfbaab..7a7e6f9 100644 --- a/internal/cli/app.go +++ b/internal/cli/app.go @@ -6,6 +6,8 @@ import ( "io" "io/ioutil" "log" + "math/rand" + "net/http" "os" "os/exec" "path/filepath" @@ -13,6 +15,8 @@ import ( "strconv" "strings" "time" + "unicode" + "unicode/utf8" "github.com/docker/docker/api/types" "github.com/docker/docker/client" @@ -44,15 +48,15 @@ func newApp() *cli.App { app.Usage = "policy compliance toolkit" app.Commands = []cli.Command{ - initCommand, + beforeCommand(initCommand, notifyVersion), } - app.Commands = append(app.Commands, beforeCommand(buildCommand, projectMustExist)) - app.Commands = append(app.Commands, beforeCommand(procedureCommand, projectMustExist)) - app.Commands = append(app.Commands, beforeCommand(schedulerCommand, projectMustExist)) - app.Commands = append(app.Commands, beforeCommand(serveCommand, projectMustExist)) - app.Commands = append(app.Commands, beforeCommand(syncCommand, projectMustExist)) - app.Commands = append(app.Commands, beforeCommand(todoCommand, projectMustExist)) + app.Commands = append(app.Commands, beforeCommand(buildCommand, projectMustExist, notifyVersion)) + app.Commands = append(app.Commands, beforeCommand(procedureCommand, projectMustExist, notifyVersion)) + app.Commands = append(app.Commands, beforeCommand(schedulerCommand, projectMustExist, notifyVersion)) + app.Commands = append(app.Commands, beforeCommand(serveCommand, projectMustExist, notifyVersion)) + app.Commands = append(app.Commands, beforeCommand(syncCommand, projectMustExist, notifyVersion)) + app.Commands = append(app.Commands, beforeCommand(todoCommand, projectMustExist, notifyVersion)) // Plugins github.Register() @@ -101,6 +105,33 @@ func ticketingMustBeConfigured(c *cli.Context) error { return nil } +// notifyVersion asynchronously notifies the availability of version updates +func notifyVersion(c *cli.Context) error { + go func() { + defer func() { + recover() // suppress panic + }() + + r, err := http.Get("http://comply-releases.s3.amazonaws.com/channel/stable/VERSION") + body, err := ioutil.ReadAll(r.Body) + if err != nil { + // fail silently + } + + version := strings.TrimSpace(string(body)) + + // only when numeric versions are present + firstRune, _ := utf8.DecodeRuneInString(string(body)) + if unicode.IsDigit(firstRune) && version != Version { + // only once every ~10 times + if rand.Intn(10) == 0 { + fmt.Fprintf(os.Stderr, "a new version of comply is available") + } + } + }() + return nil +} + func pandocMustExist(c *cli.Context) error { eitherMustExistErr := fmt.Errorf("Please install either Docker or the pandoc package and re-run `%s`", c.Command.Name)